This repository was archived by the owner on Jan 31, 2019. It is now read-only.
Skydeskprojects#747
Merged
Skydeskprojects #747
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
SkyDeskProjects commented Dec 10, 2013
Removed spaces in the filenames and fixed the issues. |
* refactors arn? method out * found bug in README * adds deprecation comment * updates front-end docs to explain ARN
Favor `until` over `while` for negative conditions and Favor modifier `while/until` usage when you have a single-line body. https://github.com/bbatsov/ruby-style-guide#syntax
Empty strings are truthy and may be passed as a payload in production and would be converted to 0, resulting in a non-working default port. The tests passed when nil was used in the test environment.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PR for #732