- Notifications
You must be signed in to change notification settings - Fork 4.4k
Offline packaging#360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offline packaging #360
Uh oh!
There was an error while loading. Please reload this page.
Conversation
brntbeer commented Apr 28, 2016 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
These scripts are also maining consistency with the way we build guides.github.com
github-pages is bumped to being at version 45 because that's what we do on guides, and consistency is awesome. updating to version 45 of github-pages made me need to update rdiscount to 2.1.8 because of github-pages dependency. we need to install pygments because though we're saying we have it for highlighter, we never included it?
We had a config for pygments, but it wasnt actually needed
matthewmccullough commented Apr 29, 2016
Though I'm only speaking to the effort, and didn't do a technical review of the changes, I'm so appreciative of you investing in the Training Kit, @brntbeer. This helps so many thousands of people, and the Training team has exciting ideas about how to take this content to the next level of the next several months. |
brntbeer commented Apr 29, 2016
Bumped |
brntbeer commented Jun 6, 2016
@crichID and @github/services-training, any thoughts on merging this soon? |
brianamarie commented Jun 6, 2016
@brntbeer I'm notoriously bad at getting things to test well locally, and that theme isn't dying here...apologies for being difficult... For testing locally, @brntbeer Thoughts on how I can fix this? |
brntbeer commented Jun 6, 2016
@brianamarie hmm, unclear. I just ran this and it worked... To be clear, you are typing the correct release number right? not just |
brianamarie commented Jun 6, 2016
@brntbeer 😆 Nope, I was literally just typing the xxxx part. Two things:
|
crichID commented Jun 6, 2016
@brianamarie here are the steps you might need to add to the beginning of @brntbeer's instructions above:
@brntbeer this works perfect and looks ✨ for foundations, intermediate, advanced, and the cheat sheets. But I am getting a 404 for |
brntbeer commented Jun 6, 2016
You should type the release number that's created in the file, this will change from version to version. For instance, if you update this from master, it will create a new commit and be something new entirely. If you run
No, it was my understanding that |
brntbeer commented Jun 6, 2016 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
@crichID yep, it fails when clicking on that link because it needs a And honestly that's fine, we're serving it with a simple python server to just verify the HTML and css is bundled up correctly. It's up to the end user (read: enterprises trapped behind a firewall wanting this documentation) to implement their correct http server with rendering of those urls, and most simple httpservers can do this. |
crichID commented Jun 6, 2016
@brntbeer of course, it had to be that simple 😉
Is this something we should document in the README? Or do you think it is trivial? Aside from the need to document this in the README, I think this looks good to 🚢! |
brntbeer commented Jun 6, 2016
@crichID it's cool, you have no idea how much i was getting frustrated over this before.
I'll make a separate PR to add this to the README as well as instructions for checking it works! |
We've had a few people ask us for offline version of the training kit! This should allow that.
A few details for this, since there's a lot going on:
pygments, since it later seemed that i needed the gem? Things still work though.cc @github/services-training for some 👀 on this. I'll likely merge it after some light review because it doesnt effect the actual deployment and rendering of the site.
To test this: