Skip to content

Conversation

@beardofedu
Copy link
Contributor

Working on adding an instructional overlay to the On Demand content using Joyride.

Things to identify:

  • How to include the <ol> element Joyride needs
  • Add ids to the relevant objects within the page
  • Add button / script to load the tour

@hectorsector, pinging you as you know the backend of On Demand much better than I.

Relevant PR: #412

@brianamarie
Copy link
Contributor

@beardofedu For background, is this to fulfill the checkbox ✔️ for the introduction to GitHub re-formatting by adding overlay with tips?

@beardofedu
Copy link
ContributorAuthor

@brianamarie Yea, I just need to figure out how to implement the ids by looking at the templates being used to convert the MD files into HTML files.

@hectorsector
Copy link
Contributor

@beardofedu I think I got it to work, although it's not pretty! But hopefully it removes a blocker that can help you get it started.

Since the sections that are called out in Joyride are parts of simple-class.html, only courses that use that layout will work -- so far the GitHub Desktop course works 👍

screen shot 2016-12-20 at 2 04 38 pm

@beardofedu
Copy link
ContributorAuthor

Don't think we need to pursue this change. Closing it for now.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@beardofedu@brianamarie@hectorsector