Skip to content
This repository was archived by the owner on Nov 1, 2017. It is now read-only.

Conversation

@jordanmccullough
Copy link
Contributor

The current process for generating event/training classnotes is tedious. It also includes copy-pasting of resources. This workflow needs to 💀.

This undertaking separates the teacher information (name, GitHub link, Twitter handle), resources, and CLI to maintain a DRY approach to the content and allow simpler maintainence of resources across all post-event classnote documents.

The new classnotes markdown will now focus on the page's content by means of the YAML, and the content body being the only custom field for CLI.

 --- layout: classnote title: Template Class Notes Title description: Sample description of event eventdate: 2013-12-12 tags: [notes] teacher: - teachers/jordanmccullough --- 

jordanmccullough added 3 commits December 9, 2013 10:14
@jordanmccullough
Copy link
ContributorAuthor

Alright @github/training-team this is ready for your 👀.

One thing for to verify as you review/edit this PR pertains to the content for the includes/materials/advanced. Right now its just "TBD". Help populating this file with Advanced course materials would be ✨. See the includes/materials/foundations for reference.

@jordanmccullough
Copy link
ContributorAuthor

Just as visual reference. The layout and content has not changed, just the way we're generating the classnote artifact.

screen shot 2013-12-09 at 10 45 03 am

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not call this teachers? You'll likely want to keep it consistent (i.e. always an Array), so the pluralized key might make more sense (esp. for open-source contributions :)

@parkr
Copy link

parkr commented Dec 9, 2013

This is awesome! 👍 Great use of includes, too.

@matthewmccullough
Copy link
Contributor

The fact that @parkr just commented on something in training.github.com makes me unreasonably happy.

Update the layout and classnote sample file to show use of array for teachers' includes
@jordanmccullough
Copy link
ContributorAuthor

@parkr You are so correct. Nice call! See d9c3c26

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

training.github.com/presentations?

@matthewmccullough
Copy link
Contributor

@jordanmccullough let me know if there's anything later tomorrow I can do to help this ship.

@jordanmccullough
Copy link
ContributorAuthor

I'm implementing MomentJS for some easier date rendering. As soon as that's in, this should be 🚢able.

@jordanmccullough
Copy link
ContributorAuthor

Historically, the event date was included in the main content to indicate when the training event occurred. Using MomentJS a nicely formatted string can be injected in based on the YAML date field.

screen shot 2013-12-11 at 5 01 47 pm

@parkr
Copy link

@jordanmccullough Why not use liquid directly, rather than Moment.js?

{{page.date | date:"%B %d %Y" }}

@jordanmccullough
Copy link
ContributorAuthor

@parkr A compelling argument for sure. Honestly, because I didn't think about exploiting Liquid's support for this. Fewer JS scripts for the win. Thanks for pointing this out!

@tlberglund
Copy link
Contributor

@jordanmccullough If I understand correctly, creating new classnotes will now require only that I make a duplicate of sample.md, right? I would ❤️ that a lot.

@parkr
Copy link

require only that I make a duplicate of sample.md

@tlberglund./script/new-classnote TITLE [opts] might be a great idea :)

@tlberglund
Copy link
Contributor

@parkr We have an internal script a lot like that! It could conceivably migrate to this repo.

Utilize Liquid function in favor of additional JS library
@jordanmccullough
Copy link
ContributorAuthor

@tlberglund That is correct! The only custom content is the CLI in the .md file.

Round II will include additional course: definitions, but for now it's exclusively the Foundations one.

Let's 🚢 this!

@brntbeer
Copy link
Member

Works for me. tested it with a template as well

@matthewmccullough
Copy link
Contributor

@jordanmccullough I love this. 👍 :shipit:

@brntbeer
Copy link
Member

yolo

brntbeer added a commit that referenced this pull request Dec 13, 2013
Classnotes Templates for Easier Post-Event Material Generation
@brntbeerbrntbeer merged commit 15d1e66 into gh-pagesDec 13, 2013
@brntbeerbrntbeer deleted the classnote-template branch December 13, 2013 21:39
@jordanmcculloughjordanmccullough removed their assignment Mar 6, 2015
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@jordanmccullough@parkr@matthewmccullough@tlberglund@brntbeer@githubteacher