This repository was archived by the owner on Nov 1, 2017. It is now read-only.
Update HydeSlides plugin to prevent help panel hover click blocking#152
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
jordanmccullough commented Dec 9, 2013
@brntbeer Can you pull this down and give it a quick test to make sure this is resolved as discussed? Thanks! |
Member
brntbeer commented Dec 9, 2013
Works on my machine! |
Contributor
matthewmccullough commented Dec 11, 2013
Build failed for what looks like a connectivity issue ( |
jordanmccullough pushed a commit that referenced this pull request Dec 11, 2013
Update HydeSlides plugin to prevent help panel hover click blocking
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a UI bug discovered by @brntbeer. The inactive, hidden help panel of the HydeSlides-Plugin prevent the editable fields from being clicked in the slide deck.
The reason: The absolutely positioned help panel was not rendered offscreen, only made opacity of
0. The absolute element placed over all other content, including slides preventing the clicking of the editable fields on the preroll slide.