Skip to content

feat: improve enterprise login#1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
setchy merged 6 commits into from
May 22, 2024
Merged

feat: improve enterprise login #1112

setchy merged 6 commits into from
May 22, 2024

Conversation

@mashiro
Copy link
Contributor

@mashiromashiro commented May 14, 2024•
edited by setchy
Loading

Fixed the following issues with GitHub Enterprise.

  1. Settings now support logging in with pat, or logging in with oauth app, after the initial login.
  2. Fixed a bug that caused the settings page to go blank when logged in only to github enterprise. ClosesSettings page goes white blank #1130
  3. Multiple logins to github enterprise are now possible with a personal token and the github app. planned to 5.7.x

setchy
setchy requested changes May 14, 2024
View reviewed changes
setchy
setchy reviewed May 14, 2024
View reviewed changes
@setchysetchy changed the title Improve enterprise loginfeat: improve enterprise loginMay 14, 2024
@setchysetchy added the enhancement New feature or enhancement to existing functionality label May 14, 2024
setchy
setchy reviewed May 14, 2024
View reviewed changes
setchy
setchy reviewed May 14, 2024
View reviewed changes
setchy
setchy reviewed May 14, 2024
View reviewed changes
@setchy
Copy link
Member

setchy commented May 21, 2024•
edited
Loading

thank for your patience @mashiro.

fyi - i'll push an update to this feature branch shortly to help move this enhancement along. watch this space 😃

@setchy
Copy link
Member

setchy commented May 21, 2024

Updates pushed. @mashiro@afonsojramos - appreciate some feedback.

the Settings changes now support logging in with pat, or logging in with oauth app, after the initial login.

it is still constrained to at-most one of each. in v5.7.x we'll focus on adding account views and a new account type model to support adding any number of each. 💪

@mashiro
Copy link
ContributorAuthor

mashiro commented May 22, 2024

@setchy Looks good!

@setchysetchy added the bug Something isn't working label May 22, 2024
@setchysetchy added this to the Release 5.6.0 milestone May 22, 2024
setchy
setchy approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@setchysetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mashiro ❤️

@setchysetchy merged commit 447a5dc into gitify-app:mainMay 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@setchysetchysetchy approved these changes

@afonsojramosafonsojramosAwaiting requested review from afonsojramosafonsojramos is a code owner

@bmulhollandbmulhollandAwaiting requested review from bmulhollandbmulholland is a code owner

Assignees

No one assigned

Labels

bugSomething isn't workingenhancementNew feature or enhancement to existing functionality

Milestone

Release 5.6.0

Development

Successfully merging this pull request may close these issues.

Settings page goes white blank

3 participants

@mashiro@setchy@afonsojramos