Skip to content

Conversation

@bmulholland
Copy link
Collaborator

@bmulholland
Copy link
CollaboratorAuthor

bmulholland commented Oct 2, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@bmulholland
Copy link
CollaboratorAuthor

Note that I deviated from https://gist.github.com/mjackson/d54b40a094277b7afdd6b81f51a0393f#get-started-upgrading-today in the PrivateRoute refactor, because https://reactrouter.com/en/main/upgrading/v5#upgrade-to-react-router-v51 says to remove , which that suggested. I think that will work okay but I don't have a good way to test this -- how can you manually go to a route in Electron? If you have a way to test the redirect works okay, and the from passes through properly, that would be good to double-check. Low-risk, though, this should be rarely (if ever) hit.

@bmulhollandbmulhollandforce-pushed the 10-02-chore_Switch_to_new_react-router_syntax branch from 8bb372b to 23967bdCompareOctober 2, 2023 10:22
@bmulhollandbmulhollandforce-pushed the 10-02-chore_Switch_to_new_react-router_syntax branch from 23967bd to 9732ce4CompareOctober 2, 2023 10:28
@bmulhollandbmulhollandforce-pushed the 10-02-chore_Switch_to_new_react-router_syntax branch from 9732ce4 to b456361CompareOctober 2, 2023 10:28
@bmulhollandbmulholland changed the title chore: Switch to new react-router syntaxchore(routing): Switch to new react-router syntaxOct 2, 2023
@afonsojramos
Copy link
Member

All you need to do is just to drop in a Link component to a certain route and you can see it in action. Tested locally and it seemed to work!

@afonsojramosafonsojramos merged commit d5d0243 into mainOct 2, 2023
@afonsojramosafonsojramos deleted the 10-02-chore_Switch_to_new_react-router_syntax branch October 2, 2023 23:22
@setchysetchy added the refactor Refactoring of existing feature label Mar 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactorRefactoring of existing feature

Development

Successfully merging this pull request may close these issues.

4 participants

@bmulholland@afonsojramos@setchy