Skip to content

Conversation

@setchy
Copy link
Member

No description provided.

@afonsojramos
Copy link
Member

@setchy do you know why it is always @bmulholland being requested in PRs?

@setchy
Copy link
MemberAuthor

@setchy do you know why it is always @bmulholland being requested in PRs?

I did look into why your name isn't showing... I thought I may have made a typo, but after triple checking it's certainly the same username... 🤔 🤷

@setchy
Copy link
MemberAuthor

@afonsojramos - is it fair to assume you have write permissions

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

Who can use this feature

People with write permissions for the repository can create or edit the CODEOWNERS file and be listed as code owners. People with admin or owner permissions can require that pull requests have to be approved by code owners before they can be merged

@setchy
Copy link
MemberAuthor

https://github.com/gitify-app/gitify/blob/main/.github/CODEOWNERS shows the file as valid 🤔 🤷

@bmulholland
Copy link
Collaborator

I think the latest line overwrites the previous one. The correct syntax is all usernames on one line

@setchysetchy merged commit 9682b42 into gitify-app:mainJan 22, 2024
@setchy
Copy link
MemberAuthor

Good catch @bmulholland 🙇

@setchysetchy deleted the docs/codeowners-update branch February 19, 2024 12:49
@setchysetchy added the documentation Improvements or additions to documentation label Mar 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentation

Development

Successfully merging this pull request may close these issues.

3 participants

@setchy@afonsojramos@bmulholland