feat: update/move "unsubscribe" icon#745
Merged
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Context
As discussed in #706, because of the new "Mark as done" button, the "unsubscribe" button was weirdly positioned, so this PR fixes it by moving icons
I also updated the "unsubscribe" icon to match Github's one (bell-slash)
Before:

After:

Discussion
I changed the order of the icons to something that felt more natural to me / something that looks more like Github's notifications interface (even though they don't provide a "mark notification as read" button).
I guess this is kind of subjective so if you see reasons to not change it, please let me know 😛