feat: better notification type icons#748
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
adufr requested review from afonsojramos, bmulholland and setchy as code owners
afonsojramos approved these changes Feb 9, 2024
Member
afonsojramos left a comment
afonsojramos left a comment There was a problem hiding this comment.
Pretty good and harmless PR, thanks! You touch on a good point though. I think we could probably have some regression testing with https://github.com/lost-pixel/lost-pixel
Collaborator
bmulholland commented Feb 12, 2024
There are snapshots from the unit tests, but I guess that's code-only |
bmulholland approved these changes Feb 12, 2024
Uh oh!
There was an error while loading. Please reload this page.
setchy added the enhancement Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Make Gitify icons match Github icons
Discussion
I had to pass the
stateparameter togetNotificationTypeIconbecause I needed this context to find the correct icon. I made it optional because it felt more accurate.I tried to find all different states/icons but I might be missing some; if so, I default to the original icon, so there shouldn't be any regression
Before / After example
Before:
After:
