chore: remove delayedHideAppIcon()#810
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
adufr requested review from afonsojramos, bmulholland and setchy as code owners
Member
setchy commented Feb 22, 2024
Nice. Any hints in a changelog at when this may have been resolved? |
setchy approved these changes Feb 22, 2024
ContributorAuthor
adufr commented Feb 22, 2024
Nope, nothing there. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the bug has been resolved; I'm running MacOS and I've had no issues with
showDockIcon: false.I think we can simply drop this function (I added
showDockIcon: falseto make it more explicit, even though it was already the default value)