Skip to content

fix: add type to urls#811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmulholland merged 1 commit into from
Feb 23, 2024
Merged

fix: add type to urls #811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/utils/helpers.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,7 +63,7 @@ export function formatSearchQueryString(
return `${title} in:title repo:${repo} updated:>${addHours(lastUpdated, -2)}`;
}

export async function getHtmlUrl(url: string, token: string){
export async function getHtmlUrl(url: string, token: string): Promise<string>{
const response = await apiRequestAuth(url, 'GET', token);

return response.data.html_url;
Expand DownExpand Up@@ -152,7 +152,7 @@ export async function generateGitHubWebUrl(
notification: Notification,
accounts: AuthState,
): Promise<string>{
let url;
let url: string;

if (notification.subject.latest_comment_url){
url = await getHtmlUrl(
Expand Down