Skip to content

Conversation

@setchy
Copy link
Member

Improve match accuracy by using regex to extract all CheckSuite title attributes

@setchysetchy added the enhancement New feature or enhancement to existing functionality label Mar 3, 2024
@setchy
Copy link
MemberAuthor

Coverage check failing due to how the percentage is calculated. All lines are covered

Copy link
Member

@afonsojramosafonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find and nice improvement! Local testing looks good as well!

@afonsojramosafonsojramos merged commit cddd3c3 into gitify-app:mainMar 3, 2024
@setchysetchy deleted the feature/checksuite-regex branch March 3, 2024 11:48
adufr pushed a commit to adufr/gitify that referenced this pull request Mar 25, 2024
* feat: use regex to extract all checksuite attributes * feat: use regex to extract all checksuite attributes * feat: use regex to extract all checksuite attributes
@setchysetchy added this to the Release 5.0.0 milestone Jul 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or enhancement to existing functionality

Development

Successfully merging this pull request may close these issues.

2 participants

@setchy@afonsojramos