refactor(icons): use standard octicons

[setchy]

Replaces the refresh, settings, logout and add account icons with those from the octicons primer design system used extensively throughout our experience.

Note: if we can find a suitable replacement for the Quit icon from https://primer.style/foundations/icons then we'll be 100% octicon powered.

	Light	Dark
Before
After

[bmulholland]

For the Quit icon, how about just an X? I know we use it elsewhere, but it's pretty standard for "close this app" and is in Octicons.

[setchy]

For the Quit icon, how about just an X? I know we use it elsewhere, but it's pretty standard for "close this app" and is in Octicons.

updated screenshots using XCircleFill as the Quit icon

[afonsojramos]

I think that grouping these changes all in one PR truly gave us a new perspective in what the changes would entail.

From a UI cohesiveness perspective, they seem as if they don't belong, mostly the ones in the bottom bar.
The size of the bottom bar also seems to have grown, but that seems like a simple mistake.

Food for thought: Maybe one alternative would be to go away with the bottom bar and adding a profile image with a dropdown with these three options, where the icons would be accompanied with a descriptive text. What do you think?

[afonsojramos]

I think that grouping these changes all in one PR truly gave us a new perspective in what the changes would entail.

From a UI cohesiveness perspective, they seem as if they don't belong, mostly the ones in the bottom bar. The size of the bottom bar also seems to have grown, but that seems like a simple mistake.

Food for thought: Maybe one alternative would be to go away with the bottom bar and adding a profile image with a dropdown with these three options, where the icons would be accompanied with a descriptive text. What do you think?

Rephrased for the sake of being more clear about the issues I see with the current change.

[setchy]

The size of the bottom bar also seems to have grown, but that seems like a simple mistake.

yes, i had noticed similar. adjusted

[setchy]

Food for thought: Maybe one alternative would be to go away with the bottom bar and adding a profile image with a dropdown with these three options, where the icons would be accompanied with a descriptive text. What do you think?

i'm not a huge fan of putting these an additional click away (behind a dropdown)

[setchy]

From a UI cohesiveness perspective, they seem as if they don't belong, mostly the ones in the bottom bar.

Personal taste perhaps. 🤷

imho, this switch to fully adopt Octicons / Primer Design System makes Gitify feel more consistent and unified 🙃

[afonsojramos]

If I am the minority here, I am open to conceding. But in that case, I think I'd switch for the no fill X, since we're not using Fill anywhere else 🧐