feat: show notification last update user#898
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
setchy added the enhancement 
afonsojramos approved these changes Mar 19, 2024
Member
afonsojramos left a comment
afonsojramos left a comment There was a problem hiding this comment.
Squeezing that sweet gh api 🤓
MemberAuthor
setchy commented Mar 19, 2024
SQUEEZE!!! |
adufr pushed a commit to adufr/gitify that referenced this pull request Mar 25, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#439
Shows the last update user when available.
Currently this logic is part of the subject enrichment process, which is controlled by
SettingsState.colors. Perhaps this setting should be renamed to something more suitable now that it handles fetching notification state/color and notification last updated user details