Fix timezone parsing functions for non-hour timezones#1547
+40 −16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The `utctz_to_altz` and `altz_to_utctz_str` functions fail to handle timezones with UTC offsets that are not a multiple of one hour. Rewrite them and add some unit tests. Fixesgitpython-developers#630
Byron approved these changes Jan 25, 2023
Member
Byron left a comment
Byron left a comment There was a problem hiding this comment.
Thanks a million, this is long overdue!
Member
Byron commented Jan 25, 2023
By the way, I can imagine a round-trip test that runs from |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
utctz_to_altzandaltz_to_utctz_strfunctions fail to handle timezones with UTC offsets that are not a multiple of one hour. Rewrite them and add some unit tests.Fixes#630