Remove optional from two member variables

[Sineaggi]

Neither working_dir nor git_dir appear to leave __init__() set to None. Let's remove the None initialization, and simply use them as type markers.

Fixes#1549

[Sineaggi]

The changes to _get_config_path and _config_reader were necessary as these functions are called during __init__, sometimes before git_path is initialized.

[Byron]

I'd prefer a test-driven approach. If working_dir cannot be none, I'd like to see what happens with bare repositories. What kind of working_dir are they expected to have?

[Sineaggi]

A bare repo should still have working_dir afaik

[Byron]

Thanks for following up.

Can you try to add clearer assertions to the different repo types, bare and non-bare, that make the relationship of these different working* directories (even more) clear?

[Byron]

Thanks!

Could you also add an assertion of the working_tree_dir for completeness? It's easy to confuse both which is what I did apparently. The working_dir is the CWD of the git repository, either the working_tree_dir or the git_dir, which I think should be an assertion for the bare and non-bare cases.

If that assertion holds, of course, I was going by the docs.

[Sineaggi]

Ok so the docs in base.py say that working_tree_dir can return none

@propertydefworking_tree_dir(self) ->Optional[PathLike]: """:return: The working tree directory of our git repository. If this is a bare repository, None is returned."""returnself._working_tree_dir

I've added a few more assertions, please check if I understood you.

[Sineaggi]

Also updated the python docs of the class to mention returning None

[Byron]

Thanks a lot for bearing with me, I was confused by the difference between working_dir and working_tree_dir, especially since there is a work_dir in gitoxide (the equivalent of working_tree_dir).

And thanks for this great contribution :)!