Ensure consistent output from git command#181
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The git command output can vary by language which would cause assertions errors when parsing the output. On POSIX system the language used by git can be adjusted by LC_MESSAGES. The special language 'C' is guaranteed to be always available and is whatever default the software has been written in (usually english, the case for git). Thus passing LC_MESSAGES to Popen will ensure we receive from git a consistent output regardless of the user preference. Addresses gitpython-developers#153
coveralls commented Jul 25, 2014
Member
Byron commented Nov 14, 2014
Thank you ! |
Byron added a commit that referenced this pull request Nov 14, 2014
Ensure consistent output from git command
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The git command output can vary by language which would cause assertions
errors when parsing the output.
On POSIX system the language used by git can be adjusted by LC_MESSAGES.
The special language 'C' is guaranteed to be always available and is
whatever default the software has been written in (usually english, the
case for git).
Thus passing LC_MESSAGES to Popen will ensure we receive from git a
consistent output regardless of the user preference.
Addresses #153