Fix CI mypy command on free-threaded Python#2040
Merged
+2 −1
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the version is represented as
3.13t, the--python-versionoption needs an operand of3.13, not3.13t.(This, and the fix here, will automatically apply to later threaded Pythons, such as 3.14t, too.)
Before this change, in the Python 3.13t run:
This isn't new--it's always happened in the
mypystep in the 3.13t job. We just never noticed it, because themypystep always reports failure even when working correctly, because there are a number of unresolved type errors. Most of them should not be suppressed, but neither I nor others have get gotten around yet to fixing them. Some of them maybe should be suppressed, but neither I nor others have gotten around yet to verifying are reasonable to suppress. (For quite some time, themypystep has step-levelcontinue-on-error, which causes it not to fail the job.)There's no connection between this and #2037 or #2038/#2039, except in the broad conceptual sense that this and #2038 share as a contributing factor that it's easy not to notice unanticipated new problems with
mypy. However, just in case, I have verified that the effect of #2039 applies the same to 3.13t as to 3.13, by first testing this on a feature branch that had not integrated #2039, and then rebasing.No change is needed in
tox.ini, even separately from that not yet listing apy313tenvironment, becausetox.inias currently written does not pass a--python-versionargument tomypy.I plan to merge this once everything passes on CI, after also verifying again that the output is as expected.
Edit: The effect is as expected and intended. I'll just wait for the rest of CI to pass before merging.