Skip to content

Fix name collision#2060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Byron merged 2 commits into from
Jul 21, 2025
+5 −5
Merged

Fix name collision #2060

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4aadb0
Fix name collision
NMertsch Jul 20, 2025
80fd2c1
Don't treat sphinx warnings as errors
NMertsch Jul 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
NextNext commit
Fix name collision
  • Loading branch information
@NMertsch
NMertsch committed Jul 20, 2025
commit a4aadb0c04bd13af824c14dcc39f88345aa5c440
8 changes: 4 additions & 4 deletions git/config.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -87,15 +87,15 @@ def __new__(cls, name: str, bases: Tuple, clsdict: Dict[str, Any]) -> "MetaParse
mutating_methods = clsdict[kmm]
for base in bases:
methods = (t for t in inspect.getmembers(base, inspect.isroutine) if not t[0].startswith("_"))
for name, method in methods:
if name in clsdict:
for method_name, method in methods:
if method_name in clsdict:
continue
method_with_values = needs_values(method)
if name in mutating_methods:
if method_name in mutating_methods:
method_with_values = set_dirty_and_flush_changes(method_with_values)
# END mutating methods handling

clsdict[name] = method_with_values
clsdict[method_name] = method_with_values
# END for each name/method pair
# END for each base
# END if mutating methods configuration is set
Expand Down