Skip to content

Respect os.Pathlike#2086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Byron merged 20 commits into from
Dec 6, 2025
+417 −344
Merged

Respect os.Pathlike#2086

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
e3f38ff
Move clone tests into dedicated file
George-Ogden Nov 27, 2025
24abf10
Allow Pathlike urls and destinations when cloning
George-Ogden Nov 27, 2025
ad1ae5f
Simplify logic with direct path conversion
George-Ogden Nov 27, 2025
5d26325
Allow Pathlike paths when creating a git repo
George-Ogden Nov 27, 2025
59c3c80
Fix missing path conversion
George-Ogden Nov 27, 2025
91d4cc5
Use os.fspath instead of __fspath__ for reading paths
George-Ogden Nov 28, 2025
0414bf7
Replace extra occurrences of str with fspath
George-Ogden Nov 28, 2025
3801505
Convert paths in constructors and large function calls
George-Ogden Nov 28, 2025
086e832
Fix union type conversion to path
George-Ogden Nov 28, 2025
b3908ed
Use converted file path
George-Ogden Nov 29, 2025
50aea99
Remove redundant `fspath`
George-Ogden Nov 29, 2025
57a3af1
Remove redundant `fspath`
George-Ogden Nov 29, 2025
df8087a
Remove a large number of redundant fspaths
George-Ogden Nov 29, 2025
1722561
Remove redundant str call
George-Ogden Nov 29, 2025
921ca8a
Limit mypy version due to Cygwin errors
George-Ogden Nov 29, 2025
b5abe0f
Merge branch 'main' into true-pathlike
George-Ogden Nov 29, 2025
12e15ba
Validate every fspath with tests
George-Ogden Nov 29, 2025
8434967
Fix type hints
George-Ogden Nov 29, 2025
1710626
Add tests with non-ascii characters
George-Ogden Dec 1, 2025
0cb55fb
Revert "Add tests with non-ascii characters"
George-Ogden Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
Remove redundant str call
  • Loading branch information
@George-Ogden
George-Ogden committed Nov 29, 2025
commit 17225612969dd68cdfa6dc6b7d5ea8d1956da533
2 changes: 1 addition & 1 deletion git/repo/base.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1386,7 +1386,7 @@ def _clone(
proc=git.clone(
multi,
"--",
Git.polish_url(str(url)),
Git.polish_url(url),
clone_path,
with_extended_output=True,
as_process=True,
Expand Down
Loading