Skip to content

Conversation

@niyaton
Copy link
Contributor

I found we cannot write log message to reflog in UTF-8 in python 2.7.5.
We can easily to reproduce this bug by executing following code to empty repository.

repo=Repo(path_to_repository) repo.create_head('test_head', logmsg='日本語')

In my environment, this code will throw following error:

UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 0: ordinal not in range(128) 

I think this bug was introduced by 4a7e7a7 and 28fdf05.

I hope this PR fix this bug.

@ByronByron added this to the v0.3.4 - python 3 support milestone Dec 11, 2014
@Byron
Copy link
Member

Thank you.
GitPython doesn't handle unicode properly, which is due to be fixed when providing support for python 3.

In the meanwhile, it shouldn't hurt to merge this PR.

Byron added a commit that referenced this pull request Dec 11, 2014
@ByronByron merged commit 891b124 into gitpython-developers:0.3Dec 11, 2014
@niyaton
Copy link
ContributorAuthor

Thank you for quick merge!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@niyaton@Byron