fix(cmd): fixed deadlock when stderr buffer overflow#357
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixed deadlock when using stderr=PIPE in Popen and Git generates enough output to a pipe such that it blocks waiting for the OS pipe buffer to accept more data (see https://docs.python.org/2/library/subprocess.html#subprocess.Popen.wait)
Member
Byron commented Oct 15, 2015
Thank you very much ! It's quite amazing how long code like this could survive in a library (as old) as GitPython. (It's probably because |
Byron added a commit that referenced this pull request Oct 15, 2015
fix(cmd): fixed deadlock when stderr buffer overflow
Byron added a commit that referenced this pull request Oct 15, 2015
Member
Byron commented Oct 15, 2015
Currently I believe GitPython does handle process channels correctly. Maybe you have an example of where this is not the case ? Those who control the process directly, may as well call |
ContributorAuthor
rikdev commented Oct 15, 2015
I use Git with Git LFS plugin. When clone a repository with the function git.Repo.clone_from, Git LFS outputs to stderr a list of downloaded files and overflow OS pipe buffer. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed deadlock when using stderr=PIPE in Popen and Git generates enough
output to a pipe such that it blocks waiting for the OS pipe buffer to
accept more data (see https://docs.python.org/2/library/subprocess.html#subprocess.Popen.wait)