Skip to content

Conversation

@nvie
Copy link
Contributor

@nvienvie commented May 30, 2016

The diff --patch output parser was missing some edge case where Git would encode non-ASCII chars in path names as octals, but these weren't decoded properly.

\360\237\222\251.txt 

Decoded via utf-8, that will return:

💩.txt 

The diff --patch parser was missing some edge case where Git would encode non-ASCII chars in path names as octals, but these weren't decoded properly. \360\237\222\251.txt Decoded via utf-8, that will return: 💩.txt
@nvienvieforce-pushed the fix-octal-escaped-path-parser-bug branch from cc1c258 to 1faf84fCompareMay 30, 2016 13:44
@nvie
Copy link
ContributorAuthor

nvie commented May 30, 2016

@Byron This is a bug we've seen in production for some time now. Happy for me to release 2.0.4 with this fix right now?

@ByronByron added this to the v2.0.4 - Bugfixes milestone May 30, 2016
@ByronByron merged commit f5089d9 into masterMay 30, 2016
@Byron
Copy link
Member

No objections, please feel free to make a release.
Something I usually do as well is to keep the milestones in sync, and thus create a new one with the upcoming release, and move all open issues from the just-released milestones into it. The latter can then be closed officially, which will then become another way for the inclined audience to see which issues/PRs made it in there.
Don't feel obliged, as I can do it when I see a disparity, but recently I noticed that I probably have made some mistakes while doing so after the fact.

In any case, thanks for your contribution :) !

@nvienvie deleted the fix-octal-escaped-path-parser-bug branch May 30, 2016 17:19
@nvie
Copy link
ContributorAuthor

nvie commented May 30, 2016

Sure, will do!

@nvie
Copy link
ContributorAuthor

nvie commented May 30, 2016

2.0.4 is now up on PyPI :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants

@nvie@Byron