Skip to content

Fix issue #470#475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Byron merged 1 commit into from
Jun 20, 2016
Merged

Fix issue #470 #475

Byron merged 1 commit into from
Jun 20, 2016

Conversation

@warsaw
Copy link
Contributor

@warsawwarsaw commented Jun 15, 2016

This just wraps stdout/stderr in safe_decode() calls to fix#470. Apologies for the lack of tests.

@ByronByron added this to the v2.0.6 - Bugfixes milestone Jun 20, 2016
@ByronByron merged commit 930d03f into gitpython-developers:masterJun 20, 2016
@Byron
Copy link
Member

Byron commented Jun 20, 2016

Thanks a lot for your contribution !

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

acknowledged

Milestone

v2.0.6 - Bugfixes

Development

Successfully merging this pull request may close these issues.

CatFileContentStream.execute() should probably safe_decode() stdout and stderr

2 participants

@warsaw@Byron