Allowed remotes to have no refs.#499
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pelsonforce-pushed the empty_refs branch 3 times, most recently from 74941c2 to c1481afCompare
Member
Byron commented Aug 19, 2016
Thank you, it's a good call to finally remove that one. If you don't get to removing the failing assertion, I will do that during the weekend. |
ContributorAuthor
pelson commented Aug 19, 2016
Thanks for the positive (fast) response. I've updated the failing test - should now be passing (it is locally). |
Member
Byron commented Aug 19, 2016
Thanks a lot! |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It makes sense to be able to write
for ref in repo.remotes.upstream.refswithout having to guard against an AssertionError.Also relates to a comment from @Byron in #480 (comment).