Skip to content

Conversation

@ankostis
Copy link
Contributor

@ankostisankostis commented Oct 23, 2016

As discussed in the last comments of #511, the projects stops relying on git's submodules to import its dependencies. That means that for TravisCI to succeed, the correct revisions must exist in PyPi, and hence, more frequent releases.

Stop importing on runtime submodules of this project: gitdb, smmap. This overrides any other method of setting `SYSPATH`, eg: - pip install -e ./gitdb.git - pip install -e . - pip install git+https://... - dependent projects for IDes(LiClipse & PyCharm). - Manual maintain path.
@ankostis
Copy link
ContributorAuthor

ankostis commented Oct 24, 2016

Indeed, CI-testing becomes impossible, unless we pip install master from git each time; but for the releases, this will not be correct, unless all sub-projects have correct masters.

From the other side, this allows to CI-test specific combinations, by modifying the .travis.yml scripts to fetch specific branches.

@codecov-io
Copy link

codecov-io commented Oct 24, 2016

Current coverage is 94.40% (diff: 100%)

Merging #544 into master will increase coverage by 0.03%

@@ master #544 diff @@ ========================================== Files 63 63 Lines 9882 9874 -8 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== - Hits 9326 9322 -4 + Misses 556 552 -4  Partials 0 0 

Powered by Codecov. Last update 5149c80...cd8d292

@ByronByron modified the milestones: v2.1.1 - Bugfixes, v2.1.2 - BugfixesDec 8, 2016
@Byron
Copy link
Member

Byron commented Mar 8, 2017

@ankostis This PR has been stale for a while now - what do you suggest we should do with it? Giving it more time is absolutely an option, and merging it certainly is too. Even though I am the biggest fan of this as GitPython will just work out of the box in the checkout location.

@ByronByron modified the milestones: v2.1.2 - Bugfixes, v2.1.3 - BugfixesMar 8, 2017
@ankostis
Copy link
ContributorAuthor

I would suggest not to merge it.
I have stopped efforts on dependent projects (my rewrite of mmap was 98% ready but have no more interest to finish it since it is not actually used by GitPython). And GitDB is probably used in few "write-only" cases, so choose the solution with least effort required.

@Byron
Copy link
Member

Byron commented Apr 9, 2017

@ankostis Thanks for letting me know. As per your recommendation, I am closing it.

@ByronByron closed this Apr 9, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants

@ankostis@codecov-io@Byron