WIP: use cygpath.exe to convert Windows paths and respect mount-points#639
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
/cygdrive/mount-point is hard-coded in GitPython's conversionsgit/utils.pysince version 2.1.3 that Cygwin support was added. This PR purports to use Cygwin'scygpath -w | -uutility for path conversions.An added benefit is support out-of-the-box for MSYS2 which is a Cygwin clone based on the excellent pacman package manager that (at last) mounts Windows-drives under root(
/).It is still a WorkInProgress (WIP) because although all travis TCs pass on the POSIX part, appveyor now fails on all non-Cygwin builds; prior to this PR, it was only Cygwin builds that were failing in a couple of TCs: https://ci.appveyor.com/project/ankostis/gitpython/build/1.0.443).