Skip to content

Conversation

@cclauss
Copy link
Contributor

matrix:
include:
- python: 3.7
dist: xenial
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might be able to move dist: xenial out one level and define it globally. If so, you can move the python declarations out to the global list and eliminate the matrix include section all together.

Copy link
ContributorAuthor

@cclausscclaussJan 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that both solutions work. While xenial is generally available, it is not the Travis default distro so I usually take the more conservative route of only using it where it is needed.

Copy link
ContributorAuthor

@cclausscclaussJan 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#831 eliminates one test when run on xenial so I think it is best to run more tests on Pythons that are compatible with the Travis CI default distro and fewer tests only on Python 3.7 and nightly.

@codecov-io
Copy link

codecov-io commented Jan 19, 2019

Codecov Report

Merging #825 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #825 +/- ## ========================================== - Coverage 94.79% 94.67% -0.12%  ========================================== Files 59 59 Lines 9600 9386 -214 ========================================== - Hits 9100 8886 -214  Misses 500 500
Impacted FilesCoverage Δ
git/objects/tree.py59.64% <0%> (-0.93%)⬇️
git/index/util.py90.69% <0%> (-0.61%)⬇️
git/index/typ.py96.82% <0%> (-0.58%)⬇️
git/refs/log.py93.84% <0%> (-0.53%)⬇️
git/objects/base.py95.83% <0%> (-0.33%)⬇️
git/refs/tag.py96.66% <0%> (-0.31%)⬇️
git/test/lib/helper.py91.86% <0%> (-0.28%)⬇️
git/refs/reference.py95.74% <0%> (-0.26%)⬇️
git/objects/commit.py91.59% <0%> (-0.25%)⬇️
git/cmd.py83.83% <0%> (-0.18%)⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a6ca8c...338cffe. Read the comment docs.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@cclauss@codecov-io@jeking3