Skip to content

Fix #889: Add DeepSource config and fix some major issues#918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Byron merged 1 commit into from
Sep 10, 2019
Merged

Fix #889: Add DeepSource config and fix some major issues #918

Byron merged 1 commit into from
Sep 10, 2019

Conversation

@mohi7solanki
Copy link
Contributor

@mohi7solankimohi7solanki commented Sep 10, 2019

No description provided.

Byron
Byron approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@ByronByron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! It's truly appreciated.
Do you think that fixes all issues referred to by #889, so it can indeed be closed? Or would you recommend keeping the issue open as there is more/less critical issues?

@ByronByron merged commit a2d8a51 into gitpython-developers:masterSep 10, 2019
@mohi7solanki
Copy link
ContributorAuthor

mohi7solanki commented Sep 10, 2019

@Byron I recommend creating new issues something like address deepsource issue and link to the issues page, by the way you have to create account and signup to keep analyzing on pr/push here https://deepsource.io/signup/

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ByronByronByron approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mohi7solanki@Byron