Skip to content

Conversation

@ulturt
Copy link
Contributor

Fix cloning to directories with a path containing Unicode characters
Closes issue #920

Copy link
Member

@ByronByron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for improving yet another instance of GitPython's confused way of handling encodings.

For a moment I thought maybe it's generally helping if force_bytes would default its encoding keyword parameter to utf-8 instead of ascii, since ascii is a valid subset of utf-8, i.e. all ascii files are also utf-8 encoded files.

Then I was uncertain if it would actually end up working that way. Your advice is appreciated, maybe it's worth another PR if you think it should work.

@ByronByron merged commit ebf4656 into gitpython-developers:masterOct 28, 2019
@ByronByron added this to the v3.0.5 - Bugfixes milestone Oct 28, 2019
@Harmon758Harmon758 mentioned this pull request Feb 18, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ulturt@Byron