Avoids env var warning when path contains $/%; fix #832#961
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
Byron commented Dec 6, 2019
Sorry for the late response and thanks a lot for the improvement! |
wip-sync referenced this pull request in NetBSD/pkgsrc-wip Mar 7, 2020
3.1.0 ===== * Switched back to using gitdb package as requirement (`gitdb#59 <https://github.com/gitpython-developers/gitdb/issues/59>`_) 3.0.9 ===== * Restricted GitDB (gitdb2) version requirement to < 4 * Removed old nose library from test requirements Bugfixes -------- * Changed to use UTF-8 instead of default encoding when getting information about a symbolic reference (`#774 <https://github.com/gitpython-developers/GitPython/issues/774>`_) * Fixed decoding of tag object message so as to replace invalid bytes (`#943 <https://github.com/gitpython-developers/GitPython/issues/943>`_) 3.0.8 ===== * Added support for Python 3.8 * Bumped GitDB (gitdb2) version requirement to > 3 Bugfixes -------- * Fixed Repo.__repr__ when subclassed (`#968 <https://github.com/gitpython-developers/GitPython/pull/968>`_) * Removed compatibility shims for Python < 3.4 and old mock library * Replaced usage of deprecated unittest aliases and Logger.warn * Removed old, no longer used assert methods * Replaced usage of nose assert methods with unittest 3.0.7 ===== Properly signed re-release of v3.0.6 with new signature (See `#980 <https://github.com/gitpython-developers/GitPython/issues/980>`_) 3.0.6 ===== | Note: There was an issue that caused this version to be released to PyPI without a signature | See the changelog for v3.0.7 and `#980 <https://github.com/gitpython-developers/GitPython/issues/980>`_ Bugfixes -------- * Fixed warning for usage of environment variables for paths containing ``$`` or ``%`` (`#832 <https://github.com/gitpython-developers/GitPython/issues/832>`_, `#961 <https://github.com/gitpython-developers/GitPython/pull/961>`_) * Added support for parsing Git internal date format (@<unix timestamp> <timezone offset>) (`#965 <https://github.com/gitpython-developers/GitPython/pull/965>`_) * Removed Python 2 and < 3.3 compatibility shims (`#979 <https://github.com/gitpython-developers/GitPython/pull/965>`_) * Fixed GitDB (gitdb2) requirement version specifier formatting in requirements.txt (`#979 <https://github.com/gitpython-developers/GitPython/pull/965>`_)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into the same issue as @kamadoatfluid in #832, as I have a mounted disk path including a
$(valid file & folder character in most operating systems, as is%). Since this is intended to catch environment variables per #662, I propose the use of regex instead to prevent irrelevant warnings from cluttering logs/console output.This PR supports all expansion conventions demonstrated in
os.path.expandvars, and also aligns with environment variable naming specifications. Illegal variables simply will cause errors and therefore don't present a security risk: word characters only, beginning witha-zor_.Supported formats:
% APPDATA %or%APPDATA%$MYVAR${MYVAR}