[API] Pull Requests#248
Merged
[API] Pull Requests #248
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Closed
MemberAuthor
bkcsoft commented Nov 25, 2016
Had to update the vendored |
tboerger added the lgtm/need 2 
bkcsoft commented Nov 25, 2016
modules/context/api.go Outdated
| } | ||
| } | ||
| // ReferencesGitRepo ... I have no clue what this does :laughing: |
MemberAuthor
There was a problem hiding this comment.
Anyone wanna have a crack at guessing what this function does? 😆
lunny requested changes Nov 25, 2016
| err.ID, err.IssueID, err.HeadRepoID, err.BaseRepoID, err.HeadBarcnh, err.BaseBranch) | ||
| } | ||
| typeErrPullRequestAlreadyExistsstruct{ |
routers/api/v1/repo/pull.go Outdated
| @@ -0,0 +1,418 @@ | |||
| // Copyright 2015 The Gogs Authors. All rights reserved. | |||
MemberAuthor
There was a problem hiding this comment.
Right, I'm not entirely sure if we can just change it, since I'm not the original author of this... @lstahlman is IIRC
bkcsoft added type/feature bkcsoftforce-pushed the api/pull-requests branch 3 times, most recently from 8b131af to 23e7cccCompareMemberAuthor
bkcsoft commented Dec 1, 2016
There, fixed the things @lunny said, should be good for merging :) |
Member
tboerger commented Dec 1, 2016
LGTM |
tboerger added lgtm/need 1 
Member
Bwko commented Dec 1, 2016
LGTM |
tboerger added lgtm/done lunny approved these changes Dec 1, 2016
MemberAuthor
bkcsoft commented Dec 2, 2016
Builds are failing because of Linting, Need to so some final testing before this goes into master though... |
bkcsoft added pr/wip bkcsoftforce-pushed the api/pull-requests branch from 73311ac to 6f22001CompareMemberAuthor
bkcsoft commented Dec 2, 2016
Builds are green! 😄 |
bkcsoft removed the status/blocked MemberAuthor
bkcsoft commented Dec 2, 2016
Verified that it works using the (currently under development) Gitea-importer in GitLab :) |
bkcsoftforce-pushed the api/pull-requests branch 2 times, most recently from 3d62890 to 4dbead0Compare
Member
strk commented Dec 2, 2016
So drop the status/wip label ? :) |
MemberAuthor
bkcsoft commented Dec 2, 2016
@strk since it was "Green" I tacked on the wip-label so no-one accidentally merged it 😛 |
Member
strk commented Dec 2, 2016
Ops, an accident occurred ! |
bkcsoft added a commit that referenced this pull request Dec 5, 2016
Merged
bkcsoft added a commit that referenced this pull request Dec 5, 2016
ethantkoenig added a commit to ethantkoenig/gitea that referenced this pull request Jan 27, 2018
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Pull-Request API
Migrated and Rebased from gogs/gogs#3755