Implementing the "get" function on a "Dictionary"#106
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sbinet reviewed Sep 30, 2019
py/dict.go Outdated
| StringDictType.Dict["get"] =MustNewMethod("get", func(selfObject, argsTuple) (Object, error){ | ||
| varlength=len(args) | ||
| iflength==0{ |
Member
There was a problem hiding this comment.
I believe "Effective Go" recommands to use switch for these kind of if-else-if code paths:
switch{caselength==0: // ...caselength>2: // ... } ...sbinet reviewed Sep 30, 2019
Member
sbinet left a comment
sbinet left a comment There was a problem hiding this comment.
some nit picks, but LGTM otherwise.
Uh oh!
There was an error while loading. Please reload this page.
Implement the "get" function and add unit test. fixes#105
ContributorAuthor
@sbinet |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the "get" function and add unit test.
fixes#105