Skip to content

Conversation

@corona10
Copy link
Collaborator

@corona10corona10 commented Aug 30, 2018

@corona10corona10 requested review from ncw and sbinetAugust 30, 2018 05:51
@corona10corona10force-pushed the gh-14 branch 2 times, most recently from bfeae97 to c3410f1CompareAugust 30, 2018 06:34
@corona10
Copy link
CollaboratorAuthor

@sbinet

I've also fixed appveyor.yml for solving gcc issue which was happened on #13
PTAL

@codecov-io
Copy link

codecov-io commented Aug 30, 2018

Codecov Report

Merging #15 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## master #15 +/- ## ========================================== - Coverage 64.43% 64.41% -0.03%  ========================================== Files 55 55 Lines 9772 9766 -6 ========================================== - Hits 6297 6291 -6  Misses 3008 3008 Partials 467 467
Impacted FilesCoverage Δ
builtin/builtin.go74.62% <100%> (-0.45%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60ae876...439862a. Read the comment docs.

@sbinet
Copy link
Member

perhaps create a PR with only the appveyor stuff?
(so it can be merged very quickly)

@corona10
Copy link
CollaboratorAuthor

@sbinet
Okay I will create a new PR by today

sbinet
sbinet previously approved these changes Aug 30, 2018
Copy link
Member

@sbinetsbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbinet
Copy link
Member

it seems travis is in one of its bad days (it doesn't manage to find your commit...)

could you rebase on top of the latest master?
also, there's a typo in the CL:
s/refernce/reference/

@sbinetsbinet dismissed their stale reviewAugust 30, 2018 13:05

travis fails

@corona10
Copy link
CollaboratorAuthor

@sbinet PTAL

Copy link
Member

@sbinetsbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

let's wait for @ncw as well.

@corona10
Copy link
CollaboratorAuthor

@ncw PTAL

@ncw
Copy link
Collaborator

ncw commented Aug 31, 2018

I think that looks great now :-)

@sbinetsbinet merged commit b55db0b into go-python:masterAug 31, 2018
@corona10corona10 deleted the gh-14 branch August 31, 2018 13:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@corona10@codecov-io@sbinet@ncw