Skip to content

Conversation

@reyoung
Copy link
Contributor

No description provided.

@reyoung
Copy link
ContributorAuthor

@sbinet@glaukiol1

Please take a review, thanks

@codecov
Copy link

codecovbot commented Jan 16, 2023

Codecov Report

Base: 74.38% // Head: 74.38% // Decreases project coverage by -0.00%⚠️

Coverage data is based on head (41b8ddf) compared to base (0cc4032).
Patch coverage: 74.19% of modified lines in pull request are covered.

Additional details and impacted files
@@ Coverage Diff @@## main #216 +/- ## ========================================== - Coverage 74.38% 74.38% -0.01%  ========================================== Files 76 76 Lines 12625 12656 +31 ========================================== + Hits 9391 9414 +23 - Misses 2562 2567 +5 - Partials 672 675 +3 
Impacted FilesCoverage Δ
stdlib/os/os.go67.72% <74.19%> (+0.70%)⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@sbinetsbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR.

I have a couple of comments.
see below.

@reyoung
Copy link
ContributorAuthor

Perhaps py.ParseTupleAndKeywords needs more comments. It is hard to understand how to set the format parameter.

:-)

@reyoung
Copy link
ContributorAuthor

Oh, I see..

py.ParseTupleAndKeywords is just like CPython API ParseTupleAndKeywords.

Perhaps need a comment to show that.

Copy link
Member

@sbinetsbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

could you please send another PR against go-python/license, adding yourself to the AUTHORS and/or CONTRIBUTORS files ?
thanks.

@reyoung
Copy link
ContributorAuthor

Here is the PR for contributors go-python/license#20 .

@sbinetsbinet merged commit 5ef0384 into go-python:mainJan 17, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@reyoung@sbinet