Skip to content

Conversation

@corona10
Copy link
Collaborator

Fixes: #23

@codecov-io
Copy link

codecov-io commented Nov 23, 2018

Codecov Report

Merging #36 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@ Coverage Diff @@## master #36 +/- ## ========================================== + Coverage 65.23% 65.25% +0.01%  ========================================== Files 56 56 Lines 10151 10148 -3 ========================================== Hits 6622 6622 + Misses 3067 3064 -3  Partials 462 462
Impacted FilesCoverage Δ
py/exception.go34.54% <0%> (+0.91%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b715616...703534e. Read the comment docs.

@corona10
Copy link
CollaboratorAuthor

@ncw
PTAL, proper unit test can't add this time.
Maybe we can add capturing fmt.Fprintf but not the easy job to this.

@corona10corona10 requested a review from ncwNovember 23, 2018 21:56
@corona10corona10 changed the title py: Fix TracebackDump to not dump duplicated exception typepy: Fix TracebackDump not to dump duplicated exception typeNov 24, 2018
@ncw
Copy link
Collaborator

ncw commented Nov 24, 2018

PTAL, proper unit test can't add this time.
Maybe we can add capturing fmt.Fprintf but not the easy job to this.

Well I think it is a definite improvement, so I'll merge it - thank you :-)

@ncwncw merged commit 2981ee9 into go-python:masterNov 24, 2018
@corona10corona10 deleted the gh-23 branch November 24, 2018 15:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@corona10@codecov-io@ncw