Skip to content

Conversation

@corona10
Copy link
Collaborator

@corona10corona10 commented Nov 24, 2018

While I work on issue #32. I found that I did not notice that
grammar_data_test.go is the auto-generated file.

So I add the test cases for #22 and also implement auto-generated license file

@corona10corona10 requested review from ncw and sbinetNovember 24, 2018 07:47
- Support auto-generated license header based on created time. - Add missed case when adding test cases go-python#22
@codecov-io
Copy link

codecov-io commented Nov 24, 2018

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #37 +/- ## ======================================= Coverage 65.23% 65.23% ======================================= Files 56 56 Lines 10151 10151 ======================================= Hits 6622 6622 Misses 3067 3067 Partials 462 462

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b715616...9198567. Read the comment docs.

@corona10
Copy link
CollaboratorAuthor

@ncw@sbinet PTAL

@ncw
Copy link
Collaborator

ncw commented Nov 25, 2018

Well spotted :-)

@ncwncw merged commit 0773b68 into go-python:masterNov 25, 2018
@corona10corona10 deleted the fix_pr_22 branch November 25, 2018 23:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@corona10@codecov-io@ncw