Skip to content

Conversation

@corona10
Copy link
Collaborator

Fixes: #41

@corona10corona10 requested a review from ncwDecember 25, 2018 02:42
@codecov-io
Copy link

codecov-io commented Dec 25, 2018

Codecov Report

Merging #42 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## master #42 +/- ## ========================================== + Coverage 65.91% 65.95% +0.04%  ========================================== Files 57 57 Lines 10206 10208 +2 ========================================== + Hits 6727 6733 +6 + Misses 3005 3002 -3 + Partials 474 473 -1
Impacted FilesCoverage Δ
py/range.go81.81% <100%> (+6.81%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e97b9b...d356b20. Read the comment docs.

@corona10
Copy link
CollaboratorAuthor

@ncw Please take a look :)

Copy link
Collaborator

@ncwncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code looks fine - can you fix the conflict though?

@corona10
Copy link
CollaboratorAuthor

@ncw
Done!
Thanks for the quick review, I hope you had happy Christmas with your family!

@ncw
Copy link
Collaborator

ncw commented Dec 29, 2018

That looks great - thanks!

Unfortunately Santa gave me and my whole family Norovirus so I guess we must have been on the naughty list after all! We've recovered now though. I hope your Christmas was better :-)

@ncwncw merged commit c140988 into go-python:masterDec 29, 2018
@corona10corona10 deleted the gh-41 branch December 29, 2018 12:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@corona10@codecov-io@ncw