Skip to content

Conversation

@corona10
Copy link
Collaborator

Now, gpython supports enumerate feature

@codecov-io
Copy link

codecov-io commented Dec 25, 2018

Codecov Report

Merging #43 into master will increase coverage by 0.3%.
The diff coverage is 72.22%.

Impacted file tree graph

@@ Coverage Diff @@## master #43 +/- ## ========================================= + Coverage 65.24% 65.55% +0.3%  ========================================= Files 56 57 +1 Lines 10150 10186 +36 ========================================= + Hits 6622 6677 +55 + Misses 3066 3040 -26 - Partials 462 469 +7
Impacted FilesCoverage Δ
builtin/builtin.go78.72% <100%> (+0.05%)⬆️
py/enumerate.go71.42% <71.42%> (ø)
py/arithmetic.go61.69% <0%> (+1.11%)⬆️
py/function.go25.95% <0%> (+1.52%)⬆️
py/tuple.go24.52% <0%> (+2.83%)⬆️
py/list.go11.83% <0%> (+2.95%)⬆️
py/sequence.go23.65% <0%> (+3.22%)⬆️
py/iterator.go73.33% <0%> (+73.33%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7ea0a4...afd9be0. Read the comment docs.

@corona10corona10force-pushed the enumerate branch 2 times, most recently from cfd27cb to 0f75714CompareDecember 25, 2018 11:37
@corona10
Copy link
CollaboratorAuthor

@ncw PTAL

Now, gpython supports enumerate feature
ncw
ncw approved these changes Dec 26, 2018
Copy link
Collaborator

@ncwncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great :-)

I didn't know enumerate took another parameter!

@ncwncw merged commit 5e97b9b into go-python:masterDec 26, 2018
@corona10
Copy link
CollaboratorAuthor

@ncw
It's the funniest part of this work!

@corona10corona10 deleted the enumerate branch December 27, 2018 00:52
@ncw
Copy link
Collaborator

ncw commented Dec 29, 2018

@ncw
It's the funniest part of this work!

Indeed, learning lots of arcane things about python!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@corona10@codecov-io@ncw