Skip to content

Conversation

@corona10
Copy link
Collaborator

Implement built-in zip

@codecov-io
Copy link

codecov-io commented Dec 28, 2018

Codecov Report

Merging #45 into master will increase coverage by 0.05%.
The diff coverage is 91.3%.

Impacted file tree graph

@@ Coverage Diff @@## master #45 +/- ## ========================================== + Coverage 65.95% 66.01% +0.05%  ========================================== Files 57 58 +1 Lines 10208 10231 +23 ========================================== + Hits 6733 6754 +21 - Misses 3002 3003 +1 - Partials 473 474 +1
Impacted FilesCoverage Δ
builtin/builtin.go78.77% <100%> (+0.05%)⬆️
py/zip.go90.9% <90.9%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c140988...7f0546d. Read the comment docs.

@corona10corona10 requested a review from ncwDecember 28, 2018 10:39
@corona10
Copy link
CollaboratorAuthor

@ncw Please take a look! Thanks alot!

Copy link
Collaborator

@ncwncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is looking very good!

A minor thing inline :-)

@corona10
Copy link
CollaboratorAuthor

@ncw
Done, Thank you for your review.
I hope your family's health improves now.
While I served a military service, one of my comrades was sick with norovirus and he told me that that time was one of the worst experience in his life.

@corona10
Copy link
CollaboratorAuthor

And always thank you for always giving me a kind review even though you are busy.

@ncw
Copy link
Collaborator

ncw commented Jan 3, 2019

That looks great now - thank you :-)

@ncwncw merged commit d8a0825 into go-python:masterJan 3, 2019
@corona10corona10 deleted the zip branch January 4, 2019 00:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@corona10@codecov-io@ncw