Skip to content

Conversation

@ncw
Copy link
Collaborator

@ncwncw commented Jan 22, 2019

This reworks the existing test framework so it can be used for
benchmarks too. Note that it now uses the subtest framework which
makes the test output much neater.

To run the benchmarks use

cd vm go test -v -run XXX -bench . 

Fixes#50

…hmarks This reworks the existing test framework so it can be used for benchmarks too. Note that it now uses the subtest framework which makes the test output much neater. To run the benchmarks use cd vm go test -v -run XXX -bench . Fixes#50
@ncwncw requested a review from corona10January 22, 2019 12:41
@codecov-io
Copy link

codecov-io commented Jan 22, 2019

Codecov Report

Merging #51 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #51 +/- ## ======================================= Coverage 66.02% 66.02% ======================================= Files 58 58 Lines 10246 10246 ======================================= Hits 6765 6765 Misses 3005 3005 Partials 476 476

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9985b49...69315d5. Read the comment docs.

Copy link
Collaborator

@corona10corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
LGTM

@corona10corona10 merged commit 95617b7 into masterJan 22, 2019
@corona10corona10 deleted the benchmarks branch January 22, 2019 12:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ncw@codecov-io@corona10