- Notifications
You must be signed in to change notification settings - Fork 98
#44 Display build information#52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
kislenko-artem commented Jan 23, 2019 • edited by corona10
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by corona10
Uh oh!
There was an error while loading. Please reload this page.
corona10 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, we don't want to use makefile for this issue.
Please follow go-releaser way.
ref: #44 (comment)
kislenko-artem commented Jan 23, 2019 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
@corona10 ok. But how will you fill these variables? go build will work anyway. if compilation will run not via makefile, variables will retain default value. |
corona10 commented Jan 23, 2019
@kislenko-artem |
corona10 commented Jan 23, 2019
Please fill the PR description if you possible. |
codecov-io commented Jan 24, 2019 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #52 +/- ## ========================================== + Coverage 66.02% 67.94% +1.91% ========================================== Files 58 59 +1 Lines 10246 10378 +132 ========================================== + Hits 6765 7051 +286 + Misses 3005 2828 -177 - Partials 476 499 +23
Continue to review full report at Codecov.
|
kislenko-artem commented Jan 24, 2019
@corona10 unfortunately I can not fix description, I can edit only title. I removed makefile, sorry for my carelessness, I missed that project build via |
corona10 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to me except we have to add add a paramter to RunREPL.
@ncw Do you have any ideas?
Uh oh!
There was an error while loading. Please reload this page.
ncw left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is looking very good :-)
However version.go is missing it's copyright header I think.
Once that is fixed up then we can merge :-)
Uh oh!
There was an error while loading. Please reload this page.
corona10 commented Feb 28, 2019
@kislenko-artem cc @ncw |
kislenko-artem commented Mar 2, 2019 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
@corona10 very very sorry, I thought my participation was ended. I added copyright information. |
corona10 commented Mar 2, 2019
Almost done, We don't want to pass paramters to RunREPL for the version information |
Uh oh!
There was an error while loading. Please reload this page.
corona10 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
corona10 commented Mar 3, 2019
Thank you for your contribution! |

Update RunREPL() to be able to display build information
Updates: #52