Skip to content

builtin: Implement builtin_iter#54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
corona10 merged 1 commit into from
Feb 14, 2019
Merged

builtin: Implement builtin_iter #54

corona10 merged 1 commit into from
Feb 14, 2019
+150 −1

Conversation

@corona10
Copy link
Collaborator

@corona10corona10 commented Feb 13, 2019•
edited
Loading

  • Implement CallIterator
  • Implement builtin iter()

Closes: #53

@corona10corona10 changed the title builtin: Implement builtin_iter[WIP] builtin: Implement builtin_iterFeb 13, 2019
@corona10
Copy link
CollaboratorAuthor

corona10 commented Feb 13, 2019

This is WIP PR do not merge!

@codecov-io
Copy link

codecov-io commented Feb 13, 2019•
edited
Loading

Codecov Report

Merging #54 into master will increase coverage by 0.32%.
The diff coverage is 88.88%.

Impacted file tree graph

@@ Coverage Diff @@## master #54 +/- ## ========================================== + Coverage 66.09% 66.42% +0.32%  ========================================== Files 58 59 +1 Lines 10332 10368 +36 ========================================== + Hits 6829 6887 +58 + Misses 3017 2989 -28 - Partials 486 492 +6
Impacted FilesCoverage Δ
builtin/builtin.go79.58% <100%> (+0.81%)⬆️
py/call_iterator.go75% <75%> (ø)
py/list.go21.3% <0%> (+8.28%)⬆️
py/sequence.go34.4% <0%> (+10.75%)⬆️
py/iterator.go86.66% <0%> (+13.33%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05fb6f3...6b0f6b1. Read the comment docs.

@corona10corona10force-pushed the builtin_iter branch 2 times, most recently from 8aceacc to 14c5813CompareFebruary 13, 2019 17:50
@corona10corona10 changed the title [WIP] builtin: Implement builtin_iterbuiltin: Implement builtin_iterFeb 13, 2019
@corona10corona10 removed the WIP label Feb 13, 2019
@corona10corona10 requested a review from ncwFebruary 13, 2019 17:58
@corona10
Copy link
CollaboratorAuthor

corona10 commented Feb 13, 2019•
edited
Loading

@ncw
Hi, Nick please take a look if you have time!

ncw
ncw reviewed Feb 13, 2019
View reviewed changes
Copy link
Collaborator

@ncwncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great! Just one minor point inline.

@corona10
Copy link
CollaboratorAuthor

corona10 commented Feb 14, 2019

@ncw
Wow, thanks for the fast review!!
I 've updated the PR as you commented!

ncw
ncw approved these changes Feb 14, 2019
View reviewed changes
Copy link
Collaborator

@ncwncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great now - merge away :-)

@corona10corona10 merged commit 344a390 into go-python:masterFeb 14, 2019
@corona10corona10 deleted the builtin_iter branch February 14, 2019 10:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncwncwncw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@corona10@codecov-io@ncw