Implement and of set#82
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
corona10 requested changes Sep 15, 2019
py/tests/set.py Outdated
| @@ -0,0 +1,16 @@ | |||
| # Copyright 2018 The go-python Authors. All rights reserved. | |||
Collaborator
There was a problem hiding this comment.
Copyright 2018 -> Copyright 2019
py/set.go Outdated
| ret:=NewSet() | ||
| b, ok:=other.(*Set) | ||
| if!ok{ | ||
| returnnil, TypeError |
Collaborator
There was a problem hiding this comment.
returnnil, ExceptionNewf(TypeError, "unsupported operand type(s) for &: '%s' and '%s'", s.Type().Name, other.Type().Name)ContributorAuthor
There was a problem hiding this comment.
I changed the return value of the function
Codecov Report
@@ Coverage Diff @@## master #82 +/- ## ========================================== + Coverage 68.65% 68.83% +0.17% ========================================== Files 59 59 Lines 10525 10534 +9 ========================================== + Hits 7226 7251 +25 + Misses 2790 2774 -16 Partials 509 509
Continue to review full report at Codecov.
|
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE: #76