Skip to content

Conversation

@DoDaek
Copy link
Contributor

Implement or of set
ISSUE: #76

Copy link
Collaborator

@corona10corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation is wrong

Expected

>>>a={1,2,3} >>>b={4,5,6} >>>a|b{1, 2, 3, 4, 5, 6} >>>4inaFalse>>>

Got

>>>a={1,2,3} >>>b={4,5,6} >>>a|b<setinstanceat0xc0003f8000>>>>a<setinstanceat0xc0003f8000>>>>4inaTrue>>>

@codecov-io
Copy link

Codecov Report

Merging #84 into master will increase coverage by 0.01%.
The diff coverage is 81.81%.

Impacted file tree graph

@@ Coverage Diff @@## master #84 +/- ## ========================================== + Coverage 68.83% 68.84% +0.01%  ========================================== Files 59 59 Lines 10534 10545 +11 ========================================== + Hits 7251 7260 +9 - Misses 2774 2775 +1 - Partials 509 510 +1
Impacted FilesCoverage Δ
py/set.go37.64% <81.81%> (+6.56%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f7bb19...8cc9353. Read the comment docs.

Copy link
Collaborator

@corona10corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corona10corona10 merged commit 261242c into go-python:masterSep 17, 2019
@DoDaekDoDaek deleted the issue-76 branch September 20, 2019 09:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@DoDaek@codecov-io@corona10