Skip to content

Fix "end" option in print func#90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
corona10 merged 4 commits into from
Sep 26, 2019
Merged

Fix "end" option in print func #90

corona10 merged 4 commits into from
Sep 26, 2019

Conversation

@Sungmin-Joo
Copy link
Contributor

@Sungmin-JooSungmin-Joo commented Sep 25, 2019•
edited
Loading

line 190 to 193.
I tried to apply the end option to the print function.
Added code performed when "end" value of parameter "kwargs" is not "nil".

@Sungmin-Joo
Fix "end" option
e0de2bd
Fix line 190 to 193. The print function corrected the end option not applied. Added code performed when "end" value of parameter "kwargs" is not "nil".
@codecov-io
Copy link

codecov-io commented Sep 25, 2019•
edited
Loading

Codecov Report

Merging #90 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## master #90 +/- ## ========================================== + Coverage 68.93% 68.94% +<.01%  ========================================== Files 60 60 Lines 10624 10626 +2 ========================================== + Hits 7324 7326 +2  Misses 2782 2782 Partials 518 518
Impacted FilesCoverage Δ
builtin/builtin.go79.74% <100%> (+0.07%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70a66f2...5425d9c. Read the comment docs.

corona10
corona10 requested changes Sep 26, 2019
View reviewed changes
Copy link
Collaborator

@corona10corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sungmin-Joo
Thank you for your contribution!!!
We need the unit test for this changed.
here is the reference

gpython/builtin/tests/builtin.py

Line 300 in 70a66f2

withopen("testfile", "w") asf:

you can check your logic through file read

@Sungmin-Joo
Fix "end" option
40d0978
Fix line 190 to 193. The print function corrected the end option not applied. Added code performed when "end" value of parameter "kwargs" is not "nil".
@Sungmin-Joo
add "end" option test
5e9266f
add "end" option test in line 312
@Sungmin-Joo
add "end" option test
5425d9c
add "end" option test add "end" option test in line 312
corona10
corona10 approved these changes Sep 26, 2019
View reviewed changes
Copy link
Collaborator

@corona10corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sungmin-Joo Thank for your contribution!
LGTM

@corona10corona10 merged commit 16d3870 into go-python:masterSep 26, 2019
@ghost
Copy link

ghost commented Sep 26, 2019

@Sungmin-Joo
The following code writes different string to the stream than in CPython:
print(1,2,3, end="||\n")

corona10 added a commit that referenced this pull request Sep 28, 2019
@corona10
Revert "Fix "end" option in print func (#90)"
316b298
This reverts commit 16d3870.
This was referenced Sep 28, 2019
Merged
Closed
corona10 added a commit that referenced this pull request Sep 28, 2019
@corona10
Revert "Fix "end" option in print func (#90)" (#94)
4b347aa
This reverts commit 16d3870.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10corona10corona10 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sungmin-Joo@codecov-io@corona10