Skip to content

Conversation

@chanxuehong
Copy link
Contributor

@chanxuehongchanxuehong commented May 30, 2020

Description

I optimized the performance of parseDateTime in the PR #1098.

Now I find that parseDateTime can still be optimized. The implementation of this version is like parseBinaryDateTime, see

funcparseBinaryDateTime(numuint64, data []byte, loc*time.Location) (driver.Value, error){

Before: BenchmarkParseDateTime-8 5117752 235 ns/op Now: BenchmarkParseDateTime-8 16154996 74.8 ns/op 

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@chanxuehong
Copy link
ContributorAuthor

I just saw #1113, please ignore this PR

@julienschmidtjulienschmidt changed the title feat: performance improvement for parseDateTimeperformance improvement for parseDateTimeMay 31, 2020
@julienschmidtjulienschmidt changed the title performance improvement for parseDateTimeutils: performance improvement for parseDateTimeMay 31, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@chanxuehong@julienschmidt