Copy route MTU from net namespace and adjust for network header size#12373
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
copybara-servicebotforce-pushed the test/cl843416148 branch from 155c937 to 49bfb48Comparecopybara-servicebotforce-pushed the test/cl843416148 branch from 49bfb48 to 0697e87Comparecopybara-servicebot changed the title copybara-servicebotforce-pushed the test/cl843416148 branch from 0697e87 to dbd0582Compare
In the original version of this commit #11857, If r.mtu has been set we skip calculating the proper MTU in tcpip/stack/route.go:Route.MTU() via endpoint.MTU and use r.mtu instead. However nothing in the callstack from tcpip/stack/stack.go:FindRoute to setting r.mtu actually adjusts the size to be able to hold the endpoint header. Hence we need to adjust it. Fixes#11856 PiperOrigin-RevId: 843416148
copybara-servicebotforce-pushed the test/cl843416148 branch from dbd0582 to 6079c8dCompareSign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy route MTU from net namespace and adjust for network header size
In the original version of this commit
#11857, If r.mtu has been set we skip
calculating the proper MTU in tcpip/stack/route.go:Route.MTU() via endpoint.MTU
and use r.mtu instead. However nothing in the callstack from
tcpip/stack/stack.go:FindRoute to setting r.mtu actually adjusts the size to be
able to hold the endpoint header. Hence we need to adjust it.
Fixes#11856