fix: Empty last chunk case in resumable upload that is not a stream#1802
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
For an upload that inherits the MediaUpload class and is not a stream, if the size of the upload is exact multiples of the chunksize, the last chunk would be empty and the generated Content-Range header will result in "Bad Request". Details: "Failed to parse Content-Range header."
Blessed4eva commented Aug 18, 2022
|
Blessed4eva approved these changes Aug 18, 2022
chalmerlowe added the kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run 
salomankevin655-beep approved these changes Dec 11, 2025
| # An empty file results in chunk_end = -1 and size = 0 | ||
| # sending "bytes 0--1/0" results in an invalid request | ||
| # Only add header "Content-Range" if chunk_end != -1 | ||
| ifchunk_end-self.resumable_progress+1==0andchunk_end!=-1: |
Contributor
There was a problem hiding this comment.
This if only fires if chunk_end != -1. But in that case, the if below also fires, overwriting this particular header. So this block as written has no effect on the end result.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an upload that inherits the MediaUpload class and is not a stream,
if the size of the upload is exact multiples of the chunksize, the last
chunk would be empty and the generated Content-Range header will result
in "Bad Request". Details: "Failed to parse Content-Range header."
Fixes#1801 🦕